Disallow empty string as argument for --output-dir-flat and --output-dir-mirror #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embg
changed the title
|
Please add a test case to the cli-tests https://github.com/facebook/zstd/tree/dev/tests/cli-tests/basic |
|
LGTM once you have a test case |
embg
changed the title
Added a test and disallowed empty string as an argument for |
terrelln
approved these changes
Aug 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dir1 == ""(fixes Buffer overrun can happen in util.c #3200 (comment))Edit: commit e1873ad fixes the buffer underflow, but I realized there is a deeper issue here. The current behavior for
--output-dir-flat=""and--output-dir-mirror=""maps"" -> "/". This is bad. Therefore, in f9f27de, I disallow empty string as an argument for those flags (and add a test verifying that behavior).